alt Hacker NewsWhat if you have two people with different ideas of how to name a certain variable and they just flip the name back and forth every release?
I like this review method too though, and like that some pr review tools have a 'suggest changes' and 'apply changes' button now too
Replies
Typically in this system you encode obligations - e.g. "eieio should review, or at least be aware of, all changes made to this library." I think that means you're unlikely in practice to have a problem like that, which (unless the team is not functioning well) requires two people who care deeply about the variable name and don't know that someone else is changing it.
I think it's a good idea to have a style guide of sorts that you can point to when people sweat the small stuff.
>What if you have two people with different ideas of how to name a certain variable and they just flip the name back and forth every release?
You fire both or at least one of them. Problem solved.
Apply rule 8 of Go
> What if you have two people with different ideas of how to name a certain variable and they just flip the name back and forth every release?
Fire both. There is no amount of skill and productivity that can justify that amount of pettiness.