I have seen this perspective a lot and I don't understand it at all. When I meet a stranger, I don't wonder if they exercise enough for me to befriend them. Same for their clothes-shopping habits, past some very basic threshold. Same for whether they pay for me.
A lot of this advice for how to improve yourself so that other people like you comes off so incredibly vain, neurotic, and juvenile.
They reflect the traits that OP values in others; these criteria wouldn't be universal. I think the thought experiment still holds: If I met myself on the street, would I like that person? If not, why not, and how can I fix that?
I firmly disagree with this advice as well; it strikes me as the sort of advice one comes up with when sitting around one's room wondering why one doesn't have any friends. The worst part about it is that it will get you doing all these activities that take up your time but don't really solve the friend problem.
Making friends isn't trivial, but it isn't a complex thing - just ask people you sort of vaguely know to hang out sometimes. Asking people to spend time together is about 10,000,000% more effective than any other strategy.