logoalt Hacker News

kortamenbratoday at 9:00 AM1 replyview on HN

I recognise myself in this post without having realised it previously.

The PR review process is flawed, it adds something, but maybe not what it intends.


Replies

dgellowtoday at 9:22 AM

One of my issue with the PR process is the way they are focused on comments first, instead of the code. You also have the same issue that email threads have, if you comment something substantial, with details you pretty much always get a response that will take one small point, and sort of ignore the rest. I also hate how noisy the discussion part is, and how GitHub handles that noise by just… hiding part of the discussion. For controversial discussion it is such a mess and horrible to track what is happening.

It’s just not a great discussion platform, while also putting that as the default tab in the PR view