logoalt Hacker News

malfistyesterday at 7:58 PM7 repliesview on HN

One of my co-workers just asked me to review his pull request that was all AI generated. 600 files were touched, over 40k lines of code added.

I'm sure he thought that was a crowning achievement, proof that AI can enable 10X developers, after all, what engineer could write 40k lines of code in a week?

I declined to review it, stating that I couldn't possibly vet 40k lines of code, and wouldn't put my reputation on the line to stamp the work as good. The PR nagged me for 2 weeks from my todo list and then disappeared. I don't know if he found another dev to get an approval from, or if the PR was abandoned. But I know for sure that him and I are on two totally separate islands around the value of LLMs.


Replies

fg137yesterday at 10:05 PM

Same here. A co-worker touched a few hundred files in a PR and asked us to review. They merged it directly to main when nobody approved it. (The repo was not set up to enforce PR approval.)

I don't personally use that feature, and I couldn't care less at this point. If our customers are frustrated by the bugs, at least my name is not on it.

show 1 reply
squidsoupyesterday at 9:39 PM

That's a process problem at your company - no developer should be proposing branches over 1k loc (or whatever your agreed tolerance threshold is) without a very good reason, vibe coded or not.

show 1 reply
afro88today at 4:39 AM

This is a branching point. One dev would find someone else and convince them to approve it. Another would redo the task (code is cheap now, right?) in a PR stack that can actually be reviewed, cleaned up etc.

I hope they were the latter.

SpaceNoodledtoday at 6:45 AM

You could surely check on the status of that PR.

otikiktoday at 8:49 AM

My review would have been along the lines of:

'Please split this PR into smaller ones'. I would even sketch which groups/phases would make sense, perhaps with the help of AI.

CamperBob2yesterday at 9:24 PM

I declined to review it, stating that I couldn't possibly vet 40k lines of code

Gee, that sounds like a job for Claude if there ever was one.

show 3 replies
LtWorftoday at 8:36 AM

A former coworker sent me an AI generated PR to review and I just said NAK after the first two issues I found and I said to not send me AI slop to review.

They went to HR who said I am more senior and I should act as a mentor (they had my same work title and were probably making 4x more due to being in USA) and I just no longer reviewed anything from them until I changed jobs.

show 1 reply