logoalt Hacker News

othmanosxtoday at 1:30 PM1 replyview on HN

I think you're missing the point of code review. By the time when the PR is ready to merge, discussions around the architecture and how the code should be structured should already be part of the tech design of a given feature. So the discussion around whether a A feature is built and planned in a maintainable way, should be way before a PR is filed. A PR review is making sure that you verify against the already agreed-upon structure, making sure everything matches the plan, and also find bugs and stuff that was missed, according to the plan.


Replies

high_na_euvtoday at 1:42 PM

Not every codebase project etc use such workflow

Also such approach doesnt work with bug fixes / regressions

show 1 reply