logoalt Hacker News

6LLvveMx2koXfwntoday at 2:36 PM3 repliesview on HN

> For instance recently I made a small change to a table and a coworker pointed out that there was a microservice I wasn't considering that wrote to that table that would break

If code reviews are important, where does testing sit? Presumably if the coworker had not been part of the code review something would have stopped the breaking change making its way to prod?


Replies

chiitoday at 2:49 PM

> something would have stopped the breaking change making its way to prod?

or a prod outage causes the knowledge to be experienced.

marcosdumaytoday at 4:07 PM

I'd guess testing is done only for the software being deployed, not for that other microservice.

At least, that's what people do by default.

skydhashtoday at 6:35 PM

> If code reviews are important, where does testing sit?

Testing is for general boundaries. If you have a formalized specs, investing in an harness and writing a lot of tests is worth it.

But more likely in a corporate system, fully documenting everything is a huge hurdle by itself. So your best bet is to gather everyone that is related to a change and let them evaluate its impact.