logoalt Hacker News

pessimizertoday at 6:49 PM1 replyview on HN

> Review means basically to think/talk about something again

The rest is not part of the definition; critics don't review movies in order to change them.

But just accepting that at face value, making code more readable is a "change." I don't know what you're trying to say here.


Replies

silva97today at 7:24 PM

To criticize is, basically, to say what should have been different. It is in the past, yet it is still about what should be changed.

> making code more readable is a "change." I don't know what you're trying to say here.

Yes and this is exactly what I am trying to say. The author limited what is the purpose of a code review like it's has really this limitation but, in practice, the code review is widely about what you think it should changed on the code by multiple reasons: readability, manutenibility, performance, security, bugs, use cases, test coverage etc.

Making code more readable is just one of the reasons why you want the code to be changed on a pull request, it's not the primary purpose.