logoalt Hacker News

hinkleyyesterday at 7:16 PM0 repliesview on HN

Everyone has to learn how much feedback they can give in a code review without making an ass of themselves. The code isn’t right at the end of that, it’s just less wrong.

On the first project I had with routine code reviews I learned to wait for one or two others to file their reviews and then I would catch everything they missed.

It was an app with too many interactive components on top few pages so perf issues and footguns were both a priority. That generates a lot more comments on CRS. There were two of us doing all of that work and the other had English as a second language so he tended to point out one or two issues and let the rest slide.