logoalt Hacker News

striking • yesterday at 11:53 PM • 3 replies • view on HN

Yeah, that's a fun way to get massive stacks of PRs that are individually incomprehensible.

Replies

wiml • today at 12:24 AM

Then reject them for being incomprehensible?

Look, if you don't think code review is worthwhile, don't do it. Just give everybody unfettered permission to merge. But don't pretend to do review if you're not trying to maintain some standard of quality.

➕ show 1 reply
t-writescode • today at 12:20 AM

How? If one PR builds off another, won’t either:

  PR 1 is size 400
  PR 2 is size 400 + 400 new
  PR 3 is size 800 + 400 new
If they’re truly disjoint, would it be so bad to get them as unique? Because otherwise, when PRs depend on each other, you tend to get “one and then one and then one”.

At least that’s how it’s worked on teams I’ve worked on that have soft size limits.

➕ show 1 reply
IshKebab • today at 3:21 AM

Luckily GitHub supports stacked PRs now! So they have to at least pass CI individually.