logoalt Hacker News

grim_ioyesterday at 5:30 PM5 repliesview on HN

Most of the colleagues I've worked with only use "git add ." without checking first.

Keys, npm directories and huge binaries are fixed by deleting them later on. The horror.


Replies

kryptisktyesterday at 5:34 PM

The problem is that those developers are also going to forget to update the ignore-by-default .gitignore to allow files, so there will be missing files. And they won't see any problems, because it works on their machine.

show 3 replies
tyreyesterday at 8:26 PM

> Keys, npm directories and huge binaries are fixed by deleting them later on. The horror.

Keys that are deleted are not gone from the git history. They’re still in the repo.

Same with giant blobs and binaries.

show 1 reply
rcvyesterday at 9:30 PM

Genuinely curious - do you all not have a code review process, or do the reviewers just not care?

show 1 reply
agentdev001yesterday at 7:30 PM

Secrets shouldn't be plain text in project directory >:[

embedding-shapeyesterday at 5:53 PM

> Most of the colleagues I've worked with only use "git add ." without checking first.

I mean I do too, then git status to check what went it, then unstage files that aren't supposed to be there, rewrite .gitignore to exclude them (usually), and finally commit. Tends to be faster than manually adding each file/path. Alternatively, I start out with `git add -p` (interactive) and go through that workflow.

show 1 reply