logoalt Hacker News

efilifeyesterday at 6:00 PM1 replyview on HN

I do this. What's wrong with this approach and how should it be done correctly?


Replies

JimDabelltoday at 5:09 AM

Pay attention to what you are staging. Generally this means `git add -p` or similar.

Pay attention to what you are committing. Generally this means looking at what you have staged before writing your commit log message.

Pay attention to what is in your pull request. Generally this means looking at your commits / draft pull request before you ask for code review.

If anybody other than you sees crap in your pull request that should obviously have been ignored, it means you have failed to pay attention to what you are doing three separate times.

show 1 reply