Double dash has long been the way to clearly indicate in plain ASCII text an em dash as distinct from a simple hyphen. So I think the author here is here emphatically reclaiming the use of the em dash while pointedly not using the Unicode character so beloved by LLMs.