> Something is a small-change if it meets all of these criteria it is less than 1,000 lines of code
Only my personal view but even 1000 LoC is not a "small change".
Yep a small changes is one computer screen of diff (36 to 48 lines) excluding generated changes (lock files, formatted files,…)
> Only my personal view but even 1000 LoC is not a "small change".
To make matters worse, they effectively implemented a YOLO allowlist to allow a specific developer to batch 1k loc changes to the set of services they are working on without requiring any scrutiny.
Crazy stuff.
They could achieve this in a much simpler way by just removing PR requirements from those users in those projects.
But this has "agents".
This struck me too, but I think it is intentionally a high limit to prevent problems like relatively low impact/high LoC tests from tipping a small change into a large one. That would encourage gamification like skipping useful scenarios to keep a change "small".
The other criteria are more important.