logoalt Hacker News

ks2048 • today at 3:00 AM • 3 replies • view on HN

Can someone point the heart of this fix? I see a bunch of change of naming of constants, etc


Replies

red75prime • today at 3:29 AM

As far as I understand it's line 1978: `goto saveStateAndReturn;`. Early return that prevents further processing.

cowlevel • today at 5:52 AM

Doesn't mix up error-need-more-data with error-invalid-data

therein • today at 5:00 AM

Had a short moment to glance at it. My guess would be BROTLI_DCHECK(s>meta_block_remaining_len <= (int)BROTLI_BLOCK_SIZE_CAP) along with BROTLI_SAFE_WITH_STATUS having that goto saveStateAndReturn on non BROTLI_DECODER_SUCCESS.