logoalt Hacker News

soon_to_be_sb • last Sunday at 11:55 AM • 1 reply • view on HN

>A Merge Request or Pull Request is the only thing that makes sense to review, and always has been since before LLMs.

Why doesn't it make sense to review smaller units of change within a big PR?


Replies

skydhash • last Sunday at 12:35 PM

Not GP, but in my experience, those small changes are usually contrived to be small. Like saving snapshots instead of being atomic and self contained. And if they are the latter, they should have been separate PR.

That’s why I usually look at the diff of the whole PR and prefer to merge by squashing. Commits inside the PR are usually noise.

➕ show 1 reply