logoalt Hacker News

dns_snek • today at 2:36 PM • 0 replies • view on HN

inlen isn't an untrusted input and it's not this calculation that's overflowing (integer overflow). It's the buffer that oveflows when you allow the operation to proceed based on faulty validation.

The caller shouldn't be responsible for enforcing preconditions of your function. They should just provide the input buffer, output buffer, their sizes and your implementation should verify whether it's safe to proceed.