logoalt Hacker News

rsyring • today at 5:28 PM • 0 replies • view on HN

One thing I've noticed about engineers, and I don't see talked about as much, is that code review is, IMO, and intrinsic skill. Some of us are wired to do it much better than others.

I personally hate code reviews and don't do well at it. But, I'm arguably really good at writing clean code that works well and is easy to maintain for the long haul.

I used to have a guy that worked for me that was on the lower end when it came to how he wrote code. But, he was absolutely great at code review.

With AI, I'm finding some of our engineers seem to be much better at code review and adapt their AI interactions accordingly. Namely, they do bigger chunks. Those who aren't as good tend to prefer much smaller chunks.

Interestingly, we had a project get out of hand with AI slop and I did an AI write moratorium. They could use AI to grok the code, develop ideas, and generate small code snippets they could then copy into the app's files, develop them further, and wire everything in. Importantly, AI could not write to any file directly. Obviously, this can be gamed, but they were open to trying it and it worked wonders for that project.

I suggested trying that for our entire org and I had one of my very good high quality engineers, who seems to be good at reviewing code, strongly object to it (with some good reasoning).